[Rust] Make Rust crate version configurable. #996
Conversation
gierlachg
force-pushed
the
rust-semver
branch
3 times, most recently
from
5da018e to
7b3f38f
Compare
| @@ -117,7 +117,7 @@ public void generate() throws IOException | |||
|
|
|||
| indent(writer, 0, "[package]\n"); | |||
| indent(writer, 0, "name = \"%s\"\n", namespace); | |||
| indent(writer, 0, "version = \"0.1.0\"\n"); | |||
| indent(writer, 0, "version = \"%s\"\n", ir.semanticVersion()); | |||
There was a problem hiding this comment.
This would be great, I +1 this.
Even better would be if we put this in codegen too, so you could start checking for semver against clients?
There was a problem hiding this comment.
I believe using a semanticVersion is optional and ir.semanticVersion() might be null.
|
Thank you for your contribution. It is common for SBE schemas to use a FIX version name or From all the file changes, I assume you need to output in Please can you make the code generator more lenient and reduce the number of changes across existing schema files? You could consider using a system property to specify the crate version instead of using the |
Exactly.
Done.
Makes sense. What about this? |
gierlachg
changed the title
Not sure if this is something you would be willing to accept.